Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix displayName cc from CTE #5536

Merged
merged 5 commits into from
Jan 10, 2025
Merged

[bugfix] fix displayName cc from CTE #5536

merged 5 commits into from
Jan 10, 2025

Conversation

dmceachernmsft
Copy link
Member

What

Updates code to be cleaner after CTE CC

Why

simplifies the code to be one line for the displayName field check

https://skype.visualstudio.com/SPOOL/_workitems/edit/3990974

How Tested

built and tested locally

@dmceachernmsft dmceachernmsft requested review from a team as code owners January 7, 2025 23:35
@dmceachernmsft dmceachernmsft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27807 / 44245
62.84%		 27807 / 44245
62.84%		 780 / 1418
55%		 2330 / 3678
63.34%
Current 27895 / 44282
62.99%		 27895 / 44282
62.99%		 780 / 1418
55%		 2344 / 3706
63.24%
Diff 88 / 37
0.15%		 88 / 37
0.15%		 0 / 0
0%		 14 / 28
-0.1%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56174 / 92227
60.9%		 56174 / 92227
60.9%		 1153 / 2655
43.42%		 3414 / 5656
60.36%
Current 56285 / 92366
60.93%		 56285 / 92366
60.93%		 1154 / 2656
43.44%		 3395 / 5666
59.91%
Diff 111 / 139
0.03%		 111 / 139
0.03%		 1 / 1
0.02%		 -19 / 10
-0.45%

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) January 9, 2025 21:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) January 10, 2025 18:12
@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1768952
  • Base size: 1768210
  • Diff size: 742

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@dmceachernmsft dmceachernmsft merged commit ebf9660 into main Jan 10, 2025
40 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/displayName-sample branch January 10, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@carocao-msft carocao-msft carocao-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

Assignees

@carocao-msft carocao-msft

@edwardlee-msft edwardlee-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmceachernmsft @carocao-msft @edwardlee-msft