Fix DT.AzureStorage regression caused by new Generation property. (#712)

Co-authored-by: amdeel <52223332+amdeel@users.noreply.github.com>
Azure · Apr 20, 2022 · 786308f · 786308f
1 parent 5730614
commit 786308f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs b/src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
@@ -1562,7 +1562,7 @@ public async Task CreateTaskOrchestrationAsync(TaskMessage creationMessage, Orch
                 }
                 else
                 {
-                    executionStartedEvent.Generation = 1;
+                    executionStartedEvent.Generation = 0;
                 }
             }
 

diff --git a/src/DurableTask.AzureStorage/Tracking/TableEntityConverter.cs b/src/DurableTask.AzureStorage/Tracking/TableEntityConverter.cs
@@ -164,38 +164,38 @@ static List<PropertyConverter> GetPropertyConvertersForType(Type type)
                     {
                         if (property != null)
                         {
-                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForInt((int)property.GetValue(o));
+                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForInt((int?)property.GetValue(o));
                             setObjectPropertyFunc = (o, e) => property.SetValue(o, e.Int32Value);
                         }
                         else
                         {
-                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForInt((int)field.GetValue(o));
+                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForInt((int?)field.GetValue(o));
                             setObjectPropertyFunc = (o, e) => field.SetValue(o, e.Int32Value);
                         }
                     }
                     else if (typeof(long?).IsAssignableFrom(memberValueType))
                     {
                         if (property != null)
                         {
-                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForLong((long)property.GetValue(o));
+                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForLong((long?)property.GetValue(o));
                             setObjectPropertyFunc = (o, e) => property.SetValue(o, e.Int64Value);
                         }
                         else
                         {
-                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForLong((long)field.GetValue(o));
+                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForLong((long?)field.GetValue(o));
                             setObjectPropertyFunc = (o, e) => field.SetValue(o, e.Int64Value);
                         }
                     }
                     else if (typeof(bool?).IsAssignableFrom(memberValueType))
                     {
                         if (property != null)
                         {
-                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForBool((bool)property.GetValue(o));
+                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForBool((bool?)property.GetValue(o));
                             setObjectPropertyFunc = (o, e) => property.SetValue(o, e.BooleanValue);
                         }
                         else
                         {
-                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForBool((bool)field.GetValue(o));
+                            getEntityPropertyFunc = o => EntityProperty.GeneratePropertyForBool((bool?)field.GetValue(o));
                             setObjectPropertyFunc = (o, e) => field.SetValue(o, e.BooleanValue);
                         }
                     }