Skip to content

[Manual Cherry-Pick] [Master] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests #5755

Merged
kodiakhq[bot] merged 10 commits intoAzure:masterfrom
nimanch:personal/nimanch/manualcherrypicke2e
Oct 28, 2021
Merged

[Manual Cherry-Pick] [Master] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests #5755
kodiakhq[bot] merged 10 commits intoAzure:masterfrom
nimanch:personal/nimanch/manualcherrypicke2e

Conversation

@nimanch
Copy link
Contributor

@nimanch nimanch commented Oct 26, 2021

This PR is a manual port of the E2E Check-in Changes made in

#5717
#5743

Changes had to be manually ported over due to additional artifacts that get build for Master Branch

Deviation from #5717

  1. Manually Port Build Images Instead of Cherry Picking since Master images.yaml builds builds more images than Release/1.2
  2. Use Master Resources instead of release/1.2 Resources for downloading build artifacts

Testing

  1. E2E Check-in Test run : https://dev.azure.com/msazure/One/_build/results?buildId=48267053&view=results
  2. Build Images Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269740&view=results
  3. Build Packages Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269877&view=results
  4. CI E2E Test Run: https://dev.azure.com/msazure/One/_build/results?buildId=48272784&view=results

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

@nimanch nimanch changed the title Manual Cherry-pick E2E Check in Files [Manual Cherry-pick][MASTER] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests Oct 26, 2021
@nimanch nimanch changed the title [Manual Cherry-pick][MASTER] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests [Manual Port] [MASTER] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests Oct 26, 2021
@nimanch nimanch changed the title [Manual Port] [MASTER] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests [Manual Port] [Master] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests Oct 26, 2021
@nimanch nimanch marked this pull request as ready for review October 26, 2021 21:13
@nimanch nimanch requested review from damonbarry and nlcamp October 26, 2021 21:14
@nimanch nimanch changed the title [Manual Port] [Master] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests [Manual Cherry-Pick] [Master] Add E2E Test[Ubuntu AMD64] as Gate for Pull Requests Oct 27, 2021
Copy link
Contributor

@and-rewsmith and-rewsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff @nimanch! Left some questions.

Copy link
Contributor

@and-rewsmith and-rewsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Let's port this to 1.2

@kodiakhq kodiakhq bot merged commit 2b3161f into Azure:master Oct 28, 2021
damonbarry pushed a commit to damonbarry/iotedge that referenced this pull request Apr 15, 2022
…Pull Requests (Azure#5755)

This PR is a manual port of the E2E Check-in Changes made in

Azure#5717
Azure#5743

Changes had to be manually ported over due to additional artifacts that get build for Master Branch

Deviation from Azure#5717 
1. Manually Port Build Images  Instead of Cherry Picking since Master images.yaml builds builds more images than Release/1.2
2. Use Master Resources instead of release/1.2 Resources for downloading build artifacts

Testing
1. E2E Check-in Test run : https://dev.azure.com/msazure/One/_build/results?buildId=48267053&view=results
2. Build Images Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269740&view=results
3. Build Packages Pipeline: https://msazure.visualstudio.com/One/_build/results?buildId=48269877&view=results
4. CI E2E Test Run: https://dev.azure.com/msazure/One/_build/results?buildId=48272784&view=results

## Azure IoT Edge PR checklist:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants