Skip to content

[Release1.1][Manual Cherry-Pick] E2E Checkin Gate #5758

Merged
kodiakhq[bot] merged 26 commits intoAzure:release/1.1from
nimanch:personal/nimanch/cherrypicke2e11
Oct 27, 2021
Merged

[Release1.1][Manual Cherry-Pick] E2E Checkin Gate #5758
kodiakhq[bot] merged 26 commits intoAzure:release/1.1from
nimanch:personal/nimanch/cherrypicke2e11

Conversation

@nimanch
Copy link
Contributor

@nimanch nimanch commented Oct 26, 2021

This PR is a manual port of #5717 , #5743 to Enable E2E Check-in Gate for Release/1.1 Branch. Due to the way Images are built (Single Stage vs Multi-stage), Some minor modifications had to be made in creating the build-images.yaml and build-packages.yaml template.

Deviation from #5717

  1. Use Powershell Scrip in e2e-setup.yaml since windows platform is also used in 1.1
  2. Add Debug Log to Print Edge Hub and Edge Agent Image
  3. Fix Artifact Filter Pattern (Edgelet artifacts involve both .gz and .deb packages)

Testing Done

  1. E2E Checkin Gate: https://dev.azure.com/msazure/One/_build/results?buildId=48273899&view=results
  2. Build Images Pipeline: https://dev.azure.com/msazure/One/_build/results?buildId=48274103&view=results
  3. Build Packages Pipeline: https://dev.azure.com/msazure/One/_build/results?buildId=48274136&view=results
  4. CI E2E Test: https://dev.azure.com/msazure/One/_build/results?buildId=48266631&view=logs&j=9ec97737-d75d-57d0-984a-aca7d53a27f6&t=dcdcf879-b5e7-5ee9-8160-60c54b14cdfe

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

@nimanch nimanch changed the title [Release1.1 Manual Cherry-Pick] E2E Checkin Gate [Release1.1][Manual Cherry-Pick] E2E Checkin Gate Oct 26, 2021
@nimanch nimanch marked this pull request as ready for review October 26, 2021 22:37
@nimanch nimanch requested a review from damonbarry October 26, 2021 22:37
@kodiakhq kodiakhq bot merged commit 32ea513 into Azure:release/1.1 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants