BREAKING CHANGE: feat: block custom NodeClass subnet on managed VNet #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comtalyst
force-pushed
the
comtalyst/block-custom-subnet-on-managed-vnet
branch
from
fc5c4eb to
4e13628
Compare
wdarko1
previously approved these changes
Dec 29, 2025
tallaxes
approved these changes
Dec 30, 2025
Collaborator
tallaxes
left a comment
tallaxes
left a comment
There was a problem hiding this comment.
LGTM. One possible (and IMO desirable) improvement would be to move the validation into the new (now existing) status validation controller - which would also set better condition / reason on failed validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
BYO NodeClass subnet within managed cluster VNet is a disallowed behavior in AKS and will stopped being maintained separately for NAP/Karpenter.
Also updated Makefile for custom VNet for testing, and updated E2E to have tests for both managed/custom VNet.
How was this change tested?
Does this change impact docs?
Release Note