test(e2e): add ZRS PV multi-zone scheduling test#1318
Draft
tallaxes wants to merge 2 commits intotallaxes/e2e/storagefrom
Draft
test(e2e): add ZRS PV multi-zone scheduling test#1318tallaxes wants to merge 2 commits intotallaxes/e2e/storagefrom
tallaxes wants to merge 2 commits intotallaxes/e2e/storagefrom
Conversation
- add test validating pod with ZRS PV schedules correctly in zone 2 - add SupportsZones() method to skip test in non-zonal regions - add EventuallyExpectPVCBound() helper function - integrate zone provider in test environment
tallaxes
force-pushed
the
tallaxes/e2e-multi-zone-pv
branch
from
60e8a55 to
9e6cb45
Compare
tallaxes
force-pushed
the
tallaxes/e2e-multi-zone-pv
branch
from
9e6cb45 to
6b393df
Compare
tallaxes
changed the title
matthchr
reviewed
Jan 7, 2026
| sigs.k8s.io/karpenter v1.6.2 | ||
| ) | ||
|
|
||
| replace sigs.k8s.io/karpenter => github.com/tallaxes/karpenter-core v0.0.0-20251221063144-7863910ee631 |
Member
There was a problem hiding this comment.
Dont forget to remove before merge.
| // considers ALL PV node affinity terms (not just the first), we intentionally | ||
| // schedule the pod in zone 2. Without the sigs.k8s.io/karpenter fix, this would fail | ||
| // because the scheduler only looked at the first zone. | ||
| zone2 := utils.MakeAKSLabelZoneFromARMZone(env.Region, zones[1]) |
Member
There was a problem hiding this comment.
Is it guaranteed that zones is always either len 0 or len 2? It can't be len 1?
If it's length 1, we'd get here and panic
tallaxes
added
area/core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an integration test that validates Karpenter correctly schedules pods with ZRS (Zone Redundant Storage) persistent volumes when the pod targets a specific zone.
This test validates the fix in kubernetes-sigs/karpenter#2743 which ensures Karpenter considers ALL PV node affinity terms during scheduling, not just the first one. ZRS disks are accessible in all zones of a region, so the PV node affinity includes multiple zone terms. Without the fix, pods targeting zone 2 would fail because only the first zone term was considered.
Changes:
VolumeBindingImmediateStorageClassEventuallyExpectPVCBound()helper functionHow was this change tested?
Does this change impact docs?
Release Note