Update code to improve connection handling and support for protobuf as content type #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PugDeveloper
commented
Jan 2, 2024
| cli := cli | ||
| for i := 0; i < clientNum; i++ { | ||
| //reuse connection if client > conns | ||
| cli := restCli[i%len(restCli)] |
There was a problem hiding this comment.
Is this how you want to reuse the client? Or did you want a more specific way to reuse certain connections?
PugDeveloper
commented
Jan 2, 2024
| if restCfg.UserAgent == "" { | ||
| restCfg.UserAgent = rest.DefaultKubernetesUserAgent() | ||
| } | ||
|
|
||
| restClients := make([]rest.Interface, 0, num) | ||
| for i := 0; i < num; i++ { | ||
| // Set the content type |
There was a problem hiding this comment.
Currently, created a flag so we can specify the content type and have this switch case.
- Wanted to make it more dynamic but wasn't sure if there is a more dynamic way without always reading the data to check the content first.
- I used the GODEBUG to double check to see if it accepts protobuf and it seems to work when I change the flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code to facilitate: