runner subcmd: support -v flag for run #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PugDeveloper
force-pushed
the
swei/addKlog
branch
from
07435a6 to
df49971
Compare
PugDeveloper
force-pushed
the
swei/addKlog
branch
from
df49971 to
4487bbd
Compare
fuweid
reviewed
Jan 12, 2024
PugDeveloper
force-pushed
the
swei/addKlog
branch
3 times, most recently
from
44bc663 to
0ffa88d
Compare
fuweid
reviewed
Jan 12, 2024
cmd/kperf/commands/runner/runner.go
Outdated
| }, | ||
| Action: func(cliCtx *cli.Context) error { | ||
| // initialize klog | ||
| klog.InitFlags(nil) | ||
| flag.Set("v", strconv.Itoa(cliCtx.Int("v"))) |
There was a problem hiding this comment.
added to check err, change flag to string, in order to have the error check work. I can leave it as int flag but the urfave/cli error kicks in before the action.
added 2 commits
January 12, 2024 05:46
update helm chart and value yaml update helm chart and value yaml
PugDeveloper
force-pushed
the
swei/addKlog
branch
from
fd158ef to
f83f9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added klog and support for -v. Using -v=9 for request debug.