Bump k8s.io/apimachinery from 0.29.3 to 0.30.2#475
Bump k8s.io/apimachinery from 0.29.3 to 0.30.2#475dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
dependabot
bot
added
dependencies
go.mod
Outdated
|
|
||
| // NOTE: kubelogin follows the same support policy as Go, which supports the last two major versions. | ||
| go 1.21 | ||
| toolchain go1.22.3 |
There was a problem hiding this comment.
@bcho is it expected? should we change L4 as well?
There was a problem hiding this comment.
umm i think it's unexpected, but it won't break thing according to this doc: https://go.dev/blog/toolchain#:~:text=There%20is%20also%20a%20new%20toolchain%20line%20in%20go.mod%20that%20specifies%20the%20minimum%20Go%20toolchain%20to%20use%20when%20working%20in%20a%20particular%20module.%20In%20contrast%20to%20the%20go%20line%2C%20toolchain%20does%20not%20impose%20a%20requirement%20on%20other%20modules.%20For%20example%2C%20a%20go.mod%20might%20say%3A
There was a problem hiding this comment.
but looks like the build is failing already, i guess dependabot is having issues with these toolchain config
There was a problem hiding this comment.
yeah i think it's an implementation issue in the dependabot side, after using the toolchain, the go version should be set with patch version in the go directive. I think we probably need a separate PR to update the go.mod settings first.
There was a problem hiding this comment.
yep i tried the go mod tidy from local, it will add an empty line in between...
dependabot
bot
force-pushed
the
dependabot/go_modules/k8s.io/apimachinery-0.30.2
branch
from
0a6bf6b to
135b5a1
Compare
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/go_modules/k8s.io/apimachinery-0.30.2
branch
from
135b5a1 to
1e6269b
Compare
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/go_modules/k8s.io/apimachinery-0.30.2
branch
from
1e6269b to
7893cd2
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/k8s.io/apimachinery-0.30.2
branch
3 times, most recently
from
7fb618d to
189733a
Compare
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.29.3 to 0.30.2. - [Commits](kubernetes/apimachinery@v0.29.3...v0.30.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/k8s.io/apimachinery-0.30.2
branch
from
189733a to
deaf772
Compare
|
The toolchain is required because of the apimachinery requires 1.22.0 now. I will include this in the next release after bumping kubelogin's go & toolchain version to 1.22+ |
|
Superseded by #493. |
dependabot
bot
deleted the
dependabot/go_modules/k8s.io/apimachinery-0.30.2
branch
2 participants
Bumps k8s.io/apimachinery from 0.29.3 to 0.30.2.
Commits
37988e5Merge remote-tracking branch 'origin/master' into release-1.30c857a38Update x/net for CVE-2023-452880407311followup to allow special characters25164f7Merge pull request #123435 from tallclair/apparmor-gacbfe0a1Merge pull request #123758 from liggitt/protobump21d26b6Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.00c29f84Merge pull request #123385 from HirazawaUi/allow-special-characters60d24f2Merge pull request #123708 from p0lyn0mial/upstream-const-watchlist-bookmark-...513d23aapimachinery/meta/types.go: define InitialEventsAnnotationKey const67cb3a8Merge pull request #123413 from seans3/tunneling-spdy-websocketsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)