Skip to content

Conversation

@cn0238
Copy link

@cn0238 cn0238 commented Mar 26, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.28%. Comparing base (15edb67) to head (d46ffed).
⚠️ Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/token/clientcertcredential.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   63.43%   54.28%   -9.16%     
==========================================
  Files          37       42       +5     
  Lines        2210     2347     +137     
==========================================
- Hits         1402     1274     -128     
- Misses        733      974     +241     
- Partials       75       99      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cn0238 cn0238 marked this pull request as ready for review March 26, 2025 21:23
@weinong
Copy link
Contributor

weinong commented Mar 28, 2025

@cn0238 can you sign the commit plz?

@cn0238
Copy link
Author

cn0238 commented Apr 1, 2025

@cn0238 can you sign the commit plz?

@weinong updated!

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong
Copy link
Contributor

weinong commented Apr 17, 2025

@cn0238 are you able to sign the commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants