-
Notifications
You must be signed in to change notification settings - Fork 115
[Bug Fix] - PoP token flow crash with nil pointer in cache.Replace when running non-root #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vineeth-thumma
wants to merge
47
commits into
Azure:main
Choose a base branch
from
vineeth-thumma:vithumma/fix_kubelogin_bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Bug Fix] - PoP token flow crash with nil pointer in cache.Replace when running non-root #736
vineeth-thumma
wants to merge
47
commits into
Azure:main
from
vineeth-thumma:vithumma/fix_kubelogin_bug
+50
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 63.43% 57.31% -6.13%
==========================================
Files 37 47 +10
Lines 2210 2448 +238
==========================================
+ Hits 1402 1403 +1
- Misses 733 880 +147
- Partials 75 165 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julienstroheker
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug - > PoP token support crashes with nil pointer in cache.Replace when running non-root
#734
kubelogin v0.2.14 panics with a nil pointer dereference in
cache.(*Cache).Replacewhen PoP tokens are enabled and cache creation fails (typically non-root users or container environments without keyring access).Root Cause
A Go nil-interface semantics bug. When NewCache() fails, a typed nil
*popcache.Cachewas stored in Options and later returned byGetPoPTokenCache(). When this typed nil was passed to an interface-typed parametercache.ExportReplace, Go wrapped it into a non-nil interface (it carries type info). The downstream nil guard if cache != nil passed, MSAL received the nil-wrapping cache, and called Replace() on a nil receiver → panic.