Imaging Add-On BugFix: Typo in automation and Generalize shutdown breaks image #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamasten
approved these changes
Aug 29, 2024
|
Thank you for the contribution @chbragg |
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
…aks image (Azure#1077) * bugfix: generalizeVM forces shutdown too early * fixed typo in param --------- Co-authored-by: Jason Masten <jamasten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*Fixed a typo in a parameter that deploys the automation.
*During the last update, a line was added that forces the shutdown of the build VM prior to generalizing the VM. The problem is that sometimes the sysprep doesn't finish before the VM is forced to shutdown. So the VM is generalized and captured into the Azure Computer Gallery, but when deploying a VM from that image, the VM will never deploy because the image is corrupt.
Issue reference
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: