Skip to content

AVD: Removed external dependencies to simplify prerequisites #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jamasten
Copy link
Contributor

@jamasten jamasten commented Sep 19, 2024

Description

Converted all custom script extensions to run commands
Removed dependency on AZ cmdlets by converting all scripts to use API calls instead
Added virtual network links for tier3
Changed AVD agent installs to use DSC extension and ZIP file provided by PG
Moved feed workspace to shared services

Issue reference

The issue this PR will close: #1083, #1061, #1054, #1016, #969, #887, #883, #871

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

@jamasten jamasten linked an issue Sep 19, 2024 that may be closed by this pull request
@jamasten jamasten marked this pull request as ready for review September 20, 2024 21:12
@jamasten jamasten requested a review from a team as a code owner September 20, 2024 21:12
@kyle-hoyer kyle-hoyer merged commit 1336c57 into main Sep 20, 2024
3 checks passed
@kyle-hoyer kyle-hoyer deleted the 1083-avd-add-on-remove-external-dependencies-to-simplify-prerequisites branch September 20, 2024 22:41
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
)

* Updated or added scripts that use API calls

* Removed module

* Removed module

* Added abbrevation for function app resources

* Restructured, Added names

* Replaced CSEs with RunCommands, Change AVD agent install method

* Fixed ANF delegation, Added FA delegation, Updated outputs

* Moved DNS zones to a dedicated file

* Moved DNS zones to a module, Moved naming to a module, Updated outputs

* Added param, Fixed settings

* Added params

* Added module for VNET links

* Updated an output

* Fixed diag setting name

* Added run command module

* Updated params, Added condition, Replaced CSE with Run Command

* Replace CSE with Run Command

* Replace CSE with Run Command, Updated conditions

* Replaced Automation Account with Function App

* Added param

* Added disk resource ID to policy, Updated deployment name

* Updated Deployed Resources

* Removed CSE for AZ module install

* Updated params & vars

* Added module for pvt link scope

* Updated params & scopes

* Updated params & vars, Replaced CSE with Run Command, Replaced runbook with function

* Updated params, vars, & outputs; Uncommented disk access policy & config; Removed validations; Replace Automation Account with Function App

* Added module for function app

* Added module for function

* Added params, conditions, module for VNET links, outputs

* Updated params & vars, Added ESRI partner ID

* Updated params & vars, Added resources for custom image, Replace runbook with function

* Updated param

* Compiled bicep changes

* Updated UI to support param changes

* Fixed the display name & description on the policy definition

* Changed param, Updated property value

* Changed param

* Removed output

* Optimized script, Thanks @shawntmeyer!

* Added conditions on API elements, Updated names for uniqueness

* Compiled bicep changes

* Updated names for uniqueness

* Removed logging, Updated header

* Fixed label value

* Fixed condition

* Fixed condition

* Added info box, Updated drop down for FSLogix

* Updated condition for backups

* Fixed UAI name

* Fixed resource names

* Removed unnecessary file

* Changed the file name

* Added data collection endpoint

* Added data collection endpoint

* Updated param name

* Changed param name & role assignment file

* Added support for LAW

* Added PLS for LAW, Added DCE, Updated resource names

* Updated params, role assignment file, & outputs

* Updated params, vars, conditions, resource names, app service plan, app settings & role assignment; Removed file share; Added A record

* Created file

* Updated param & condition

* Updated param & condition

* Updated params

* Added file for storage account role assignments

* Updated params

* Compiled bicep changes

* Added PLS input, Updated monitoring for diff svcs, Added tag resource

* Added PLS for DCE

* Updated deployment name for uniqueness

* Fixed DCE api version for MAG

* Fixed linked resource ID for LAW

* Compiled bicep changes

* Fixed key vault name

* Fixed key vault name

* Compiled bicep changes

* Fixed outputs

* Added param

* Compiled bicep changes

* Updated param values

* Compiled bicep changes

* Updated params

* Updated params, Fixed names

* Removed unnecessary files

* Updated param, Fixed names

* Removed param

* Updated params, Fixed names

* Updated params

* Updated params

* Updated params & var, Fixed names

* Updated params

* Updated params

* Updated params

* Updated params

* Removed unnecessary file

* Compiled bicep changes

* Fixed log access for AVD Insights

* Added a param

* Added param, Fixed role assignments & names

* Compiled bicep changes

* Reduced SKU for app svc plan

* Fixed output for null condition

* Added deployment condition for PLS

* Added dependencies

* Added a comment

* Fixed storage account name

* Updated output to use child output

* Added names for disk access

* Changed param

* Changed param; Updated names

* Compiled bicep changes

* Changed output for storage account resource Ids

* Compiled bicep changes

* Removed params & var

* Removed params

* Fixed spacing

* Removed params

* Compiled bicep changes

* Removed params, Replace AZ cmdlets with API calls, Fixed storage account name, Removed output

* Fixed label

* Added decorator & params, Changed file, Removed param

* Created file

* Added decorator

* Compiled bicep changes

* Added fix for inconsistent casing on resource IDs

* Compiled bicep changes

* Added param, Fixed JSON string, Removed output

* Added param

* Compiled bicep changes

* Added output

* Added param for storage account name prefix

* Added param, Fixed param value

* Fixed substring length

* Removed param attributes

* Compiled bicep changes

* Fixed timestamp, output, URIs, & authentication

* Fixed tag

* Fixed tags

* Moved file

* Renamed file

* Removed param, Changed deployment order, Updated locations, Moved feed workspace

* Removed location input

* Moved feed workspace

* Compiled bicep changes

* Removed location param

* Removed file prereqs

* GitHub Action: Build Bicep to JSON

* Fixed deployment scope for feed workspace

* Fixed default values for params

* Simplified group input; Changed default value & visibility

* Fixed deployment name

* Added api call for control plan location, Fixed conditions, Updated names

* Added role assignments for existing app group references

* Compiled bicep changes

* Updated clean up script to use an API call

* Updated params

* Changed role definition

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVD Add-On: remove external dependencies to simplify prerequisites
2 participants