Add Firewall Option for SKU #794 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 3, 2024 15:08
jamasten
approved these changes
Feb 6, 2024
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
* update firewall sku tier options to allow for standard and basic * update allowed values * build json * build json and update readme * set dnssettings as conditional based on SKU * add dns settings for Standard tier condition * update dns optoins based on SKU type * update test values * test values * test dns values * update * test updates * test updates with conditionals * build json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added optional SKUs for Azure Firewall parameters
Updated UI definition to expose a dropdown for the selectable SKUs
Add notes that let the user knows if they are not selecting Premium, the environment is not SCCA compliant
Updated firewall deployment to optionally deploy dnsSettings based on SKU
Updated readme files
Tested and verified deployment
Issue reference
The issue this PR will close: #794
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: