Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics for Prometheus #29

Merged
merged 8 commits into from
Mar 29, 2024
Merged

feat: add metrics for Prometheus #29

merged 8 commits into from
Mar 29, 2024

Conversation

avtakkar
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 69.53%. Comparing base (39ad5d0) to head (c750262).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   69.04%   69.53%   +0.49%     
==========================================
  Files          35       36       +1     
  Lines        1767     1812      +45     
==========================================
+ Hits         1220     1260      +40     
- Misses        547      552       +5     
Files Coverage Δ
internal/metrics/prometheus.go 100.00% <100.00%> (ø)
cmd/proxy/main.go 0.00% <0.00%> (ø)

@avtakkar avtakkar merged commit 4167c15 into main Mar 29, 2024
6 of 8 checks passed
@avtakkar avtakkar deleted the mon branch March 29, 2024 19:57
avtakkar added a commit that referenced this pull request Jul 24, 2024
avtakkar added a commit that referenced this pull request Jul 24, 2024
Signed-off-by: Aviral Takkar <avtakkar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant