Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor router and add tests, use periodic ID token refresh in release CI #38

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

avtakkar
Copy link
Contributor

No description provided.

@avtakkar
Copy link
Contributor Author

Might address #37

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 63.23529% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 71.50%. Comparing base (d69157d) to head (a3301f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   70.81%   71.50%   +0.68%     
==========================================
  Files          36       36              
  Lines        1823     1825       +2     
==========================================
+ Hits         1291     1305      +14     
+ Misses        532      520      -12     
Files Coverage Δ
internal/context/context.go 100.00% <ø> (ø)
internal/oci/mirror.go 80.35% <100.00%> (ø)
internal/remote/reader.go 83.66% <100.00%> (ø)
internal/routing/tests/mock.go 92.85% <100.00%> (ø)
cmd/proxy/main.go 0.00% <0.00%> (ø)
internal/state/state.go 65.07% <66.66%> (ø)
internal/routing/router.go 43.75% <57.40%> (+10.41%) ⬆️

@avtakkar avtakkar merged commit 9fee397 into main Apr 11, 2024
8 checks passed
@avtakkar avtakkar deleted the refactor2 branch April 11, 2024 17:33
avtakkar added a commit that referenced this pull request Jul 24, 2024
… release CI (#38)

* feat: refactor to improve readability and coverage

* ci: add periodic id token refresh
avtakkar added a commit that referenced this pull request Jul 24, 2024
… release CI (#38)

* feat: refactor to improve readability and coverage

* ci: add periodic id token refresh

Signed-off-by: Aviral Takkar <avtakkar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant