Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move cache to pkg, simplify handlers #42

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor: move cache to pkg, simplify handlers #42

merged 2 commits into from
Apr 12, 2024

Conversation

avtakkar
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (dd3559f) to head (44deeba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   69.37%   69.72%   +0.34%     
==========================================
  Files          34       34              
  Lines        1757     1757              
==========================================
+ Hits         1219     1225       +6     
+ Misses        538      532       -6     
Files Coverage Δ
internal/files/store/mockstore.go 85.71% <ø> (ø)
internal/files/store/store.go 82.08% <100.00%> (ø)
internal/handlers/files/handler.go 84.61% <ø> (ø)
internal/handlers/root.go 48.88% <100.00%> (ø)
internal/handlers/v2/handler.go 39.13% <100.00%> (ø)
internal/handlers/v2/mirror.go 91.07% <ø> (ø)
internal/handlers/v2/registry.go 63.76% <ø> (ø)
pkg/cache/filecache.go 82.65% <100.00%> (ø)
pkg/cache/item.go 72.58% <ø> (ø)
pkg/cache/syncmap.go 93.54% <ø> (ø)
... and 1 more

@avtakkar avtakkar changed the title refactor: move cache to pkg refactor: move cache to pkg, simplify handlers Apr 12, 2024
@avtakkar avtakkar merged commit e0efc39 into main Apr 12, 2024
8 checks passed
@avtakkar avtakkar deleted the refactor6 branch April 12, 2024 23:26
avtakkar added a commit that referenced this pull request Jul 24, 2024
* refactor: move cache to pkg

* refactor: simplify handlers
avtakkar added a commit that referenced this pull request Jul 24, 2024
* refactor: move cache to pkg

* refactor: simplify handlers

Signed-off-by: Aviral Takkar <avtakkar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant