Update sonic-dash-ha and sonic-swss-common together due to dependencies#1578
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prabhataravind, in sonic-dash-ha/.gitmodules, should the url be url = https://github.com/Azure/sonic-dash-api.msft.git? |
@yue-fred-gao, I see. I can try updating this url but I am curious as to why dash-api needs to be a submodule of dash-ha. Both are already submodules of buildimage repo. We handle such dependencies between submodules like swss and swss-common or swss and sairedis without creating a submodule relationship between them. Can we revisit this logic? |
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
prabhataravind
force-pushed
the
paravind/submodule_update_202506
branch
from
fe158a9 to
9fdd44a
Compare
|
/azp run Azure.sonic-buildimage-msft.PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like the issue is not just the URL/branch. I think you probably didn't know the existence of submodule when you ported the change over. So the submodule is not created in sonic-dash-ha. Please run "git submodule add --name crates/sonic-dash-api-proto/sonic-dash-api --branch 202506 https://github.com/Azure/sonic-dash-api.msft.git crates/sonic-dash-api-proto/sonic-dash-api" |
|
There is something special about rust binding for protobuf. it needs to generate rust source code from proto files. We are looking at ways to remove submodule. |
hi @yue-fred-gao, it looks like auto cherry-pick somehow didn't add the submodules. I need to check on this with build team but do you mind raising a PR for 202506 sonic-dash-ha repo with the right set of fixes? @zjswhhh for viz. |
|
hi @prabhataravind, I created PR Azure/sonic-dash-ha.msft#19 to fix the submodule issue. Then you can pick up the change in this PR. |
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
|
/azp run Azure.sonic-buildimage-msft.PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
thanks @yue-fred-gao |
3 participants
Why I did it
sonic-dash-ha and sonic-swss-common have mutual dependencies and need to be updated together to avoid compilation failures
Work item tracking
How I did it
Update both submodules together
How to verify it
Make sure the build succeeds
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)