Fix test_dscp_to_queue_mapping_uniform_mode#1954
Fix test_dscp_to_queue_mapping_uniform_mode#1954rick-arista wants to merge 1 commit intoAzure:202412from
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "TUNNEL_DECAP_TABLE:IPINIP_SUBNET" : { | ||
| "tunnel_type":"IPINIP", | ||
| "dscp_mode":"uniform", | ||
| "decap_dscp_to_tc_map":"AZURE", |
There was a problem hiding this comment.
this change is not apply to a single platform and a single release. @sdszhang , is this the real fix?
There was a problem hiding this comment.
@rick-arista is this needed for every platform? Can we limit it to TH5 only? As we don't see this on Nvidia platform, changing this may affect the result of their platform.
There was a problem hiding this comment.
@rick-arista do you know why this failure only happens on 202412 branch? but not on 202505 anymore?
There was a problem hiding this comment.
I'm not entirely sure. There were other changes on 202505 to this section of the code that I think might apply a similar fix.
There was a problem hiding this comment.
hi @rick-arista , do you mind to follow the fix on master and port the azure_qos_exists check:
There was a problem hiding this comment.
This is the code I am referring to:
And this is where the flag being used that affects the code:
3 participants
Why I did it
This fixes test_dscp_to_queue_mapping_uniform_mode for TH5. This attr is required for setting the custom qos map for ipinip tunnels.
Work item tracking
How I did it
How to verify it
Manually tested
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)