[action] [PR:96] Add vip_v4 and vip_v6 to DPU DASH_HA_SCOPE_TABLE#15
Merged
prabhataravind merged 1 commit intoAzure:202506from Aug 31, 2025
Merged
Conversation
### why There is a mismatch between DASH_HA_SCOPE_TABLE in DPU sonic-db and SAI HA_SCOPE definition. vip_v4 and vip_v6 exist in the latter but not in DASH_HA_SCOPE_TABLE. DashHaOrch has to implement complicated logic to get vip_v4 and vip_v6 from DASH_HA_SET_TABLE. To simplify DashHaOrch design, vip_v4 and vip_v6 are added to DASH_HA_SCOPE_TABLE. Accordingly, hamgrd needs to adapt to it. ### what this PR does 1. Update DASH_HA_SCOPE_TABLE until it receives DASH_HA_SET_CONFIG from corresponding ha_set actor 2. Copy vip_v4 and vip_v6 from DASH_HA_SET_CONFIG to DASH_HA_SCOPE_TABLE 3. Update UT
Collaborator
Author
|
Original PR: sonic-net/sonic-dash-ha#96 |
Collaborator
Author
|
/azp run |
prabhataravind
approved these changes
Aug 31, 2025
prabhataravind
pushed a commit
to prabhataravind/sonic-dash-ha.msft
that referenced
this pull request
Sep 8, 2025
Unless clippy is disabled for some specific reason, I think we should have it be enabled. It pointed out a couple of errors in swss-common that I fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
There is a mismatch between DASH_HA_SCOPE_TABLE in DPU sonic-db and SAI HA_SCOPE definition. vip_v4 and vip_v6 exist in the latter but not in DASH_HA_SCOPE_TABLE. DashHaOrch has to implement complicated logic to get vip_v4 and vip_v6 from DASH_HA_SET_TABLE. To simplify DashHaOrch design, vip_v4 and vip_v6 are added to DASH_HA_SCOPE_TABLE. Accordingly, hamgrd needs to adapt to it.
what this PR does