[action] [PR:89] Suppress update from consumer bridge if there is no change#16
Merged
prabhataravind merged 1 commit intoAzure:202506from Aug 31, 2025
Merged
Conversation
### why There is very frequent update from DPU_STATE. It appears pmon collecting dpu state and update this table every minute. But in each cycle, it makes multiple no change update to the table. redis doesn't seem to filter it. It sends notification regardlessly. Also hamgrd sends no-change update to ProducerBridge or ZmqProducerBridge. The latter sends notification to DPU via zmq periodically propagated from DPU_STATE update. DashHaOrch treats no-change update as warning and it also pollutes swss.rec in DPU. ### what this PR does - consumer bridge filters no change update. It compares the update to previous state. If there is no change, it will just drop the notification. - remove tracing span lifecycle events if logger is initialized from swss. span events are good for debugging long operations but they are also too chatty. They can be enabled if swbusd/hamgrd are started with RUST_LOG env, which has highest priority in initializing loggers. - producer bridge keeps a cache of previous update and filter out the no-change update.
Collaborator
Author
|
Original PR: sonic-net/sonic-dash-ha#89 |
Collaborator
Author
|
/azp run |
prabhataravind
approved these changes
Aug 31, 2025
prabhataravind
pushed a commit
to prabhataravind/sonic-dash-ha.msft
that referenced
this pull request
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
There is very frequent update from DPU_STATE. It appears pmon collecting dpu state and update this table every minute. But in each cycle, it makes multiple no change update to the table. redis doesn't seem to filter it. It sends notification regardlessly.
Also hamgrd sends no-change update to ProducerBridge or ZmqProducerBridge. The latter sends notification to DPU via zmq periodically propagated from DPU_STATE update. DashHaOrch treats no-change update as warning and it also pollutes swss.rec in DPU.
what this PR does