Skip to content

enable ipv6 topo for test_default_route replace https://github.com/so… #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanmo96 merged 1 commit into from
Feb 20, 2026
Merged

enable ipv6 topo for test_default_route replace https://github.com/so… #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3628,9 +3628,7 @@ route/test_default_route.py:
route/test_default_route.py::test_default_route_set_src:
xfail:
reason: "xfail for IPv6-only topologies, need add support for IPv6-only"
conditions_logical_operator: or
conditions:
- "https://github.com/sonic-net/sonic-mgmt/issues/19925 and '-v6-' in topo_name"
- "https://github.com/sonic-net/sonic-buildimage/issues/24537 and 't0-isolated-d256u256s2' in topo_name"

route/test_default_route.py::test_default_route_with_bgp_flap:
Expand Down
22 changes: 15 additions & 7 deletions tests/route/test_default_route.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from tests.common.utilities import wait_until
from tests.common.utilities import find_duthost_on_role
from tests.common.utilities import get_upstream_neigh_type, get_all_upstream_neigh_type
from tests.common.utilities import is_ipv6_only_topology
from tests.common.helpers.syslog_helpers import is_mgmt_vrf_enabled


Expand Down Expand Up @@ -153,6 +154,9 @@ def test_default_route_set_src(duthosts, tbinfo):
config_facts = asichost.config_facts(
host=duthost.hostname, source="running")['ansible_facts']

ipv6_only = is_ipv6_only_topology(tbinfo)
logger.info("IPv6-only topology: {}".format(ipv6_only))

lo_ipv4 = None
lo_ipv6 = None
los = config_facts.get("LOOPBACK_INTERFACE", {})
Expand All @@ -166,14 +170,16 @@ def test_default_route_set_src(duthosts, tbinfo):
elif ip.version == 6:
lo_ipv6 = ip

pytest_assert(lo_ipv4, "cannot find ipv4 Loopback0 address")
if not ipv6_only:
pytest_assert(lo_ipv4, "cannot find ipv4 Loopback0 address")
pytest_assert(lo_ipv6, "cannot find ipv6 Loopback0 address")

rtinfo = asichost.get_ip_route_info(ipaddress.ip_network("0.0.0.0/0"))
pytest_assert(rtinfo['set_src'],
"default route do not have set src. {}".format(rtinfo))
pytest_assert(rtinfo['set_src'] == lo_ipv4.ip,
"default route set src to wrong IP {} != {}".format(rtinfo['set_src'], lo_ipv4.ip))
if not ipv6_only:
rtinfo = asichost.get_ip_route_info(ipaddress.ip_network("0.0.0.0/0"))
pytest_assert(rtinfo['set_src'],
"default route do not have set src. {}".format(rtinfo))
pytest_assert(rtinfo['set_src'] == lo_ipv4.ip,
"default route set src to wrong IP {} != {}".format(rtinfo['set_src'], lo_ipv4.ip))

rtinfo = asichost.get_ip_route_info(ipaddress.ip_network("::/0"))
pytest_assert(
Expand Down Expand Up @@ -263,7 +269,9 @@ def test_default_route_with_bgp_flap(duthosts, tbinfo):
uplink_ns = get_uplink_ns(
tbinfo, bgp_name_to_ns_mapping, config_facts['DEVICE_NEIGHBOR_METADATA'])

af_list = ['ipv4', 'ipv6']
ipv6_only = is_ipv6_only_topology(tbinfo)
af_list = ['ipv6'] if ipv6_only else ['ipv4', 'ipv6']
logger.info("IPv6-only topology: {}, testing address families: {}".format(ipv6_only, af_list))

try:
# verify the default route is correct in the app db
Expand Down