[202412][PR:22322] Add trimmed packet size margin#1033
Merged
r12f merged 1 commit intoAzure:202412from Feb 22, 2026
Merged
Conversation
What is the motivation for this PR? In some cases a small difference in the expected trimmed packet size has been observed (+/- 4 bytes). The trimmed packet's size depends on the asic's cell size, minus any metadata contained in the first cell. Since the variable number of trailing bytes is part of the packet's payload we can ignore this difference and add a margin to any size checks. How did you do it? Expected packets are now matched by prefix minus the margin size, and an additional assertion was added that the size is within +/- the packet size margin value. How did you verify/test it? Manually tested
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidm-arista
approved these changes
Feb 20, 2026
|
LGTM |
r12f
commented
Feb 22, 2026
Contributor
Author
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
Bypassing CI, due to pipeline being flaky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync PR #22322 from sonic-net/sonic-mgmt to 202412.
Original PR: sonic-net/sonic-mgmt#22322