Add explicit config for creating acl counter#882
Closed
rgarofano-arista wants to merge 1 commit intoAzure:202412from
Closed
Add explicit config for creating acl counter#882rgarofano-arista wants to merge 1 commit intoAzure:202412from
rgarofano-arista wants to merge 1 commit intoAzure:202412from
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rgarofano-arista the PR checker issue has been fixed in sonic-net/sonic-mgmt#18348, pls rebase your PR to latest 202412. |
Signed-off-by: Ryan Garofano <rgarofano@arista.com>
rgarofano-arista
force-pushed
the
fix-acl-rule-creation
branch
from
65cd324 to
f216b08
Compare
11 tasks
Contributor
|
this change might be redundant - see discussion in the master branch PR. 202412 also has this change: 
|
|
@rgarofano-arista Pls check https://github.com/sonic-net/sonic-swss/blob/98b9d353a11a51244adca5c7d21832e9824f4499/orchagent/aclorch.cpp#L2579 as Riff mentioned. Could you check if SAI capability query fails for ACL counter. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
the auto cherry-pick is merged in #1029. I think we can close this PR as duplicated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orchagent will create an acl counter by default when creating an acl rule. In the packet trimming
test_acl_action_with_trimmingtestcase it is applying some json configuration to create an acl table with the disable trim action. Because there is no counter action in this configuration the Broadcom SAI (and possibly other SAI implementations) fails to create the acl counter resulting in no acl rules being applied to the newly created acl table. This fix explicitly adds the counter as an acl table action, which allows the SAI to create both the counter and the acl rules which we want to test.