[action] [PR:21143] configlet/test_add_rack.py Add comparison ignore for extra entries added by generic patcher#977
Merged
mssonicbld merged 1 commit intoAzure:202412from Jan 29, 2026
Conversation
…ded by generic patcher <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: When patching the DUT to remove t0 peers, the test fails the DB comparison due to extra entries being added to APP_DB. These entries only get added when generic patcher in SONiC (`config apply-patch`) is used to remove t0 from the DUT. Ideally this should be fixed in `config apply-patch` code. This PR is a workaround for the issue since the extra entries are harmless and does not get used. Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft_202412 - [x] 202505 ### Approach #### What is the motivation for this PR? `configlet/test_add_rack.py` is failing. #### How did you do it? Adding extra entries to ignore. These entries seems to be harmless and not used. However it is not understood why it is being added by `config apply-patch`. Again, ideally this should be fixed in `config apply-patch` code. This PR is a workaround for the issue since the extra entries are harmless and does not get used. #### How did you verify/test it? Test no longer fails #### Any platform specific information? Broadcom platform is used for testing. #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#21143 |
Collaborator
Author
|
/azp run |
12 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
When patching the DUT to remove t0 peers, the test fails the DB comparison due to extra entries being added to APP_DB.
These entries only get added when generic patcher in SONiC (
config apply-patch) is used to remove t0 from the DUT.Ideally this should be fixed in
config apply-patchcode. This PR is a workaround for the issue since the extra entries are harmless and does not get used.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
configlet/test_add_rack.pyis failing.How did you do it?
Adding extra entries to ignore. These entries seems to be harmless and not used. However it is not understood why it is being added by
config apply-patch.Again, ideally this should be fixed in
config apply-patchcode. This PR is a workaround for the issue since the extra entries are harmless and does not get used.How did you verify/test it?
Test no longer fails
Any platform specific information?
Broadcom platform is used for testing.
Supported testbed topology if it's a new test case?
Documentation