Skip pfc storm event based on hwsku#989
Open
rgarofano-arista wants to merge 1 commit intoAzure:202412from
Open
Skip pfc storm event based on hwsku#989rgarofano-arista wants to merge 1 commit intoAzure:202412from
rgarofano-arista wants to merge 1 commit intoAzure:202412from
Conversation
11 tasks
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@r12f do we have m1/m2 deployment with 202412? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Skipping swss event verification in telemetry/test_events.py for m1 and m2 topos as this testing is out of scope for the deployment.
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
We were seeing failures while trying to verify the pfc storm event on m1 topos. This is because there is no QoS config. After inquiring with Microsoft we decided to skip this part of the test since QoS is not needed for the deployment.
How did you do it?
Refactored existing skip logic to use a list of hwsku's for skipping instead of topology.
How did you verify/test it?
Verified the expected hwsku's were being skipped for broadcom.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation