[202503] [sff-mgr] Disable SFF manager support for all CMIS transceivers#57
Merged
arlakshm merged 1 commit intoAzure:202503from Nov 24, 2025
Merged
Conversation
…ers (#710) * [sff-mgr] Disable SFF manager support for all CMIS transceivers Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Change pipeline pool to sonictest * Added unit test to improve code coverage --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
@bingwang-ms for viz.. |
prgeor
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick PR for sonic-net/sonic-platform-daemons#710
Description
For certain CMIS transceivers which have transceiver type as "QSFP+ or later with CMIS", SFF manager also starts controlling Tx disable in addition to CMIS manager.
Hence, SFF manager needs to skip handling such CMIS transceivers. Following code needs to be modified to addressed this
https://github.com/sonic-net/sonic-platform-daemons/blob/69ce3870c5dcd5ab4d5a6ec0b784da827acb1d0e/sonic-xcvrd/xcvrd/sff_mgr.py#L387-L389
Motivation and Context
For certain CMIS transceivers which have transceiver type as "QSFP+ or later with CMIS", the SFF manager was also controlling Tx disable in addition to the CMIS manager. This created a conflict where both managers would attempt to control the same transceiver, leading to potential race conditions and unexpected behavior.
The previous type check only filtered based on the string prefix "QSFP28" or "QSFP+", which would incorrectly include CMIS modules that report as "QSFP+ or later with CMIS".
Added explicit CMIS API check using
common.is_cmis_api()to the transceiver filtering logicHow Has This Been Tested?
Unrelated change
The pipeline pool has been updated to sonictest since sonic-common is not supported anymore.
Additional Information (Optional)
MSFT ADO - 35947863