[action] [PR:1723] Fix deadlock between syncd and orchagent syncd during initialization failure#104
Merged
mssonicbld merged 1 commit intoAzure:202412from Jan 24, 2026
Conversation
…failure When syncd requests a shutdown, orchagent may be blocked waiting for a response to an init view (or other NOTIFY) command. Since syncd stops processing commands while waiting for the shutdown response, orchagent never receives its response and cannot acknowledge the shutdown request - resulting in a deadlock. This fix adds the selectable channel to the select loop during shutdown-wait mode and handles incoming commands appropriately: - NOTIFY commands receive a SAI_STATUS_FAILURE response to unblock the waiting orchagent - Other commands are logged and ignored This prevents orchagent from hanging until timout when syncd is failing. This fix - sonic-net/sonic-buildimage#24799
Collaborator
Author
|
Original PR: sonic-net/sonic-sairedis#1723 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When syncd requests a shutdown, orchagent may be blocked waiting for a response to an init view (or other NOTIFY) command. Since syncd stops processing commands while waiting for the shutdown response, orchagent never receives its response and cannot acknowledge the shutdown request - resulting in a deadlock.
This fix adds the selectable channel to the select loop during shutdown-wait mode and handles incoming commands appropriately:
This prevents orchagent from hanging until timout when syncd is failing.
This fix - sonic-net/sonic-buildimage#24799