Add progressive batching for VRF/VXLAN device cleanup#202
Open
ypcisco wants to merge 1 commit intoAzure:202506from
Open
Add progressive batching for VRF/VXLAN device cleanup#202ypcisco wants to merge 1 commit intoAzure:202506from
ypcisco wants to merge 1 commit intoAzure:202506from
Conversation
Signed-off-by: Yash Pandit <ypcisco@gmail.com>
anish-n
reviewed
Feb 14, 2026
| processed += batch_vrfs.size(); | ||
| batch_vrfs.clear(); | ||
|
|
||
| unsigned int increment = std::max(1U, current_batch_size >> 2); |
There was a problem hiding this comment.
Just curious what is the value of doing it in increments, why don't we just set the batch size to some static number like 100 and do it in a batch like that? I see that we have stated there is startup netlink congestion if we batch too soon, have we seen performance issues if we batch too soon?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it