Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subscription placement dependency on mg #140

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: subscription placement dependency on mg #140

merged 2 commits into from
Nov 5, 2024

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Nov 5, 2024 •
edited
Loading

Fixes #138

Description

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 5, 2024
@matt-FFFFFF matt-FFFFFF merged commit 4d0a811 into main Nov 5, 2024
8 of 11 checks passed
@matt-FFFFFF matt-FFFFFF deleted the matt-FFFFFF/issue138 branch November 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

@jaredfholgate jaredfholgate Awaiting requested review from jaredfholgate

Assignees
No one assigned
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Subscription placement dependency missing
2 participants
@matt-FFFFFF @jtracey93