-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
467 feature request add dsts support #482
Open
handsomejack-42
wants to merge
9
commits into
main
Choose a base branch
from
467-feature-request-add-dsts-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9575c6a
refactor: remove UserRealmURIPrefix from authority.Info
handsomejack-42 2c371ea
refactor(oauth): use named tests for WithTenant to improve test outpu…
handsomejack-42 9113780
test(oauth): add WithTenant test-cases to increase method test coverage
handsomejack-42 acf530a
refactor(oauth): use constructor for new client in comm.HTTPClient.JS…
handsomejack-42 5c855f3
refactor(oauth): rename aad instance discovery endpoint const
handsomejack-42 b71b8b8
refactor(oauth): make WithTenant extensible with authority types
handsomejack-42 a725f82
refactor(authority): use authority.ADFS instead of re-defined ADFS const
handsomejack-42 3b1540d
refactor(confidential): fakeClient accepts authority as param
handsomejack-42 99f29ff
feat(oauth): add support for dSTS authority type
handsomejack-42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that dSTS has a single tenant, there is no need for this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there still is a value in checking that we will fail the execution in case anyone tries to do WithTenant on dSTS flow