Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gradle and velocity repo #46

Merged
merged 3 commits into from
May 21, 2024
Merged

chore: update gradle and velocity repo #46

merged 3 commits into from
May 21, 2024

Conversation

RealBauHD
Copy link
Contributor

No description provided.

@MrMicky-FR
Copy link
Member

Good catch for the repo changes and upgraded dependencies (I was sure I had updated Gradle in my last commit but turns out I forgot 😅)

just about the version.toml, usually I think it’s an interesting feature especially when lots of dependencies are duplicated, but here it mixes unrelated dependencies between platforms all in the same place, where before they were each confined to the build.gradle of the module. And also using different versions between modules is expected : for example an older version of Gson is bundled with old Minecraft versions, so it shouldn’t be the last version, but when we are bundling it we no longer have this constraint

@RealBauHD
Copy link
Contributor Author

I overlooked that with gson, does that apply to others?
We could differentiate between the individual modules with empty lines and comments, since dependencies like nlogin are almost everywhere.

@MrMicky-FR
Copy link
Member

Unless I missed one, isn't nLogin the only dependency included more than twice ? And the majority of dependencies are only included once

@RealBauHD
Copy link
Contributor Author

netty, shadow and blossom

@MrMicky-FR
Copy link
Member

I don't see where one of them is included at least three times (so more than twice) 😅 I see the following:

  • Shadow: 2x (Universal & Universal Legacy)
  • Blossom: 2x (Sponge Legacy & Velocity)

And for Netty indeed is included 3 times, but no more than twice with the same version (for compatibility, same as Gson)

@RealBauHD
Copy link
Contributor Author

You're right, should I revert the libs.versions.toml use, so you could push the other changes?

@MrMicky-FR
Copy link
Member

Yes would be perfect !

@RealBauHD RealBauHD changed the title chore: update and make use of libs.versions chore: update gradle and velocity repo May 21, 2024
@MrMicky-FR MrMicky-FR merged commit 4704819 into Azuriom:master May 21, 2024
1 check passed
@MrMicky-FR MrMicky-FR added the enhancement New feature or request label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants