Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md after nomination #11

Merged
merged 7 commits into from
Dec 30, 2023
Merged

Update README.md after nomination #11

merged 7 commits into from
Dec 30, 2023

Conversation

pitdagosti
Copy link
Member

Proposal for closing #10

@pitdagosti pitdagosti added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Dec 30, 2023
@pitdagosti pitdagosti self-assigned this Dec 30, 2023
@pitdagosti pitdagosti linked an issue Dec 30, 2023 that may be closed by this pull request
[FEAT]: Revamp toplevel README.md #10
Closed
3 tasks
@gmacario
Copy link
Member

Maybe we could also update the cover image by replacing it with something like https://twitter.com/baroloteam/status/1740735338031571052 and linking it to the Community Award submission form instead?

@pitdagosti
Copy link
Member Author

You mean, creating a new QR code?

@gmacario
Copy link
Member

You mean, creating a new QR code?

No, just the link from the image to the form, something like

[![2023-12-29-xxx.png](assets/2023-12-29-xxx.png)](https://www.jotform.com/form/233544823564157)

@pitdagosti
Copy link
Member Author

What do you think?

EE2366BA-6619-43FE-A118-B29E7AC37AE5

@gmacario
Copy link
Member

I am not sure that the URL https://www.jotform.com/form/233544823564157 inside the image is useful. But the link when clicking on the image IMHO is.

@pitdagosti
Copy link
Member Author

ahhhh now I got it

@gmacario gmacario self-requested a review December 30, 2023 11:44
gmacario
gmacario approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@gmacario gmacario left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one commit which comments out the first image.

Now LGTM. Merging PR as soon as Super-Linter approves

@gmacario gmacario merged commit 70b1d0c into main Dec 30, 2023
6 checks passed
@gmacario gmacario deleted the pitdagosti-patch-1 branch December 30, 2023 11:45
This was referenced Dec 30, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacario gmacario gmacario approved these changes

Assignees

@pitdagosti pitdagosti

Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Revamp toplevel README.md
2 participants
@pitdagosti @gmacario