Skip to content

docs: add pre-merge testing requirement to CONTRIBUTING.md #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maddefientist merged 1 commit into from
Jan 29, 2026
Merged

docs: add pre-merge testing requirement to CONTRIBUTING.md #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,22 @@ mypy src/
3. Make changes with tests
4. Run `pytest` and `ruff check`
5. Open a PR
6. **Pre-merge testing** (see below)

## Pre-Merge Testing (REQUIRED)

**Before merging any PR, test the dev branch as an actual install:**

```bash
# Install from dev branch (catches dependency/import issues)
uv tool install --force "git+https://github.com/maddefientist/SlopeSniper.git@bagwatcher-release#subdirectory=mcp-extension"

# Verify CLI works
slopesniper version
slopesniper status
```

> **Why this matters:** v0.3.2 shipped with a breaking import (`websockets` module missing at runtime). Local `pytest` passed because it uses the dev venv with all deps installed, but the global install failed because the new dependency wasn't being pulled. Always test the real install path before merging.

## Code Style

Expand Down
Loading