Skip to content

Conversation

@KoeppelSoftwareEngineer
Copy link
Collaborator

Description Message, I am creating a "Pull Request".

@coveralls
Copy link

coveralls commented Dec 3, 2025

Pull Request Test Coverage Report for Build 20164783365

Details

  • 0 of 131 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/database.py 0 4 0.0%
backend/datamodel.py 0 40 0.0%
backend/main.py 0 87 0.0%
Totals Coverage Status
Change from base Build 19474966801: 0.0%
Covered Lines: 0
Relevant Lines: 145

💛 - Coveralls

Copy link
Member

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. I will go through installing this locally, checking the README, and let you know how it goes.

I didn't review the frontend. Once I launch this I will take a look and give some comments.

Copy link
Member

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments, I will rewrite the README later

@KoeppelSoftwareEngineer
Copy link
Collaborator Author

Nice

Copy link
Member

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an easier way of handling IDs, which is with hashlib. This way we will get rid of bson types.

I can implement that, but for you, perhaps is a good idea to simply assume that ìdis astr, and do not use ObjectIdfor any of thebackend/main.py` implementations.Once you get rid of these, I will take over and finish this pull request by implementing the handling of hashes for ids (so you can easily see what I mean).

So, in short:

  1. Go through my final comments
  2. Delete ObjectId usage and simply assume id is a string you can safely use
  3. Let me know by asking me to re-review
  4. I handled the id situation with hashes
  5. You take a look
  6. We merge

version: str
content: dict # JSON schema
updated_at: datetime
id: str = Field(..., description="Unique identifier for the schema")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have another suggestion for ID: using hashlib instead and create a hash depending on the schema.dict() content.

this way we get rid off bson types

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend/main.py is independent of bson types. SchemaDefinition --> "id: str" 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .py files are updated id: str,

❓Do you still wnat to implement id generation using hashlib (creating a hash based on schema.dict() content) )?🤔

Copy link
Member

@JosePizarro3 JosePizarro3 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still wnat to implement id generation using hashlib (creating a hash based on schema.dict() content) )?

Yes, exactly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID: using hashlib implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polish the structure of the repo and add NextJS generated GUI

5 participants