-
Notifications
You must be signed in to change notification settings - Fork 0
1 polish the structure of the repo and add nextjs generated gui #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1 polish the structure of the repo and add nextjs generated gui #2
Conversation
Pull Request Test Coverage Report for Build 20164783365Details
💛 - Coveralls |
JosePizarro3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. I will go through installing this locally, checking the README, and let you know how it goes.
I didn't review the frontend. Once I launch this I will take a look and give some comments.
JosePizarro3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor comments, I will rewrite the README later
|
Nice |
JosePizarro3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an easier way of handling IDs, which is with hashlib. This way we will get rid of bson types.
I can implement that, but for you, perhaps is a good idea to simply assume that ìdis astr, and do not use ObjectIdfor any of thebackend/main.py` implementations.Once you get rid of these, I will take over and finish this pull request by implementing the handling of hashes for ids (so you can easily see what I mean).
So, in short:
- Go through my final comments
- Delete ObjectId usage and simply assume
idis a string you can safely use - Let me know by asking me to re-review
- I handled the id situation with hashes
- You take a look
- We merge
backend/datamodel.py
Outdated
| version: str | ||
| content: dict # JSON schema | ||
| updated_at: datetime | ||
| id: str = Field(..., description="Unique identifier for the schema") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have another suggestion for ID: using hashlib instead and create a hash depending on the schema.dict() content.
this way we get rid off bson types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend/main.py is independent of bson types. SchemaDefinition --> "id: str" 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .py files are updated id: str,
❓Do you still wnat to implement id generation using hashlib (creating a hash based on schema.dict() content) )?🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still wnat to implement id generation using hashlib (creating a hash based on schema.dict() content) )?
Yes, exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID: using hashlib implemented.
… hash-b ased ID implementation
Description Message, I am creating a "Pull Request".