refactor(operations): dont repeat yourself

BBVA · Dec 21, 2017 · e839197 · e839197
1 parent 8213018
commit e839197
Showing 1 changed file with 17 additions and 26 deletions.
diff --git a/mirrorgate-dashboard/src/components/tiles/operations-metrics/operations-component.html b/mirrorgate-dashboard/src/components/tiles/operations-metrics/operations-component.html
@@ -63,6 +63,20 @@ <h3 class="title-desc">
       Error: 2
     };
 
+    function sendEvent(metricName, description, color){
+      document.dispatchEvent(new CustomEvent('HeadsUp', {
+        detail: {
+          title: metricName,
+          description: description,
+          date: new Date(),
+          url: '',
+          color: color
+        }
+      }));
+
+      firstTime = false;
+    }
+
     function checkOperationMetricsToSendEvent(responseTimeState, errorsRateState, responseTimeAlertingLevels, errorsRateAlertingLevels){
         var metricName = '';
         var thresholds = '';
@@ -78,17 +92,7 @@ <h3 class="title-desc">
             state = Math.max(errorsRateState, responseTimeState);
             color = state == stateMapping['Error'] ? 'red' : state == stateMapping['Warn'] ? 'yellow' : 'blue';
 
-            document.dispatchEvent(new CustomEvent('HeadsUp', {
-              detail: {
-                title: metricName,
-                description: description,
-                date: new Date(),
-                url: '',
-                color: color
-              }
-            }));
-
-            firstTime = false;
+            sendEvent(metricName, description, color);
           }
 
         } else {
@@ -105,21 +109,10 @@ <h3 class="title-desc">
           }
 
           description = 'Greater than the threshold (' + thresholds + ')';
-
           state = Math.max(errorsRateState, responseTimeState);
           color = state == stateMapping['Error'] ? 'red' : state == stateMapping['Warn'] ? 'yellow' : 'blue';
 
-          document.dispatchEvent(new CustomEvent('HeadsUp', {
-            detail: {
-              title: metricName,
-              description: description,
-              date: new Date(),
-              url: '',
-              color: color
-            }
-          }));
-
-          firstTime = false;
+          sendEvent(metricName, description, color);
         }
     };
 
@@ -132,11 +125,9 @@ <h3 class="title-desc">
                 : metrics.errorsRate <= errorsRateAlertingLevels.error ? stateMapping['Warn']
                 : stateMapping['Error'];
 
-        var state = Math.max(responseTimeState, errorsRateState);
-
         checkOperationMetricsToSendEvent(responseTimeState, errorsRateState, responseTimeAlertingLevels, errorsRateAlertingLevels);
 
-        return state;
+        return Math.max(responseTimeState, errorsRateState);
     }
 
     MGComponent({