[hotfix] user info #208
Merged
[hotfix] user info #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjaena
reviewed
Mar 31, 2024
| import kotlinx.coroutines.flow.asStateFlow | ||
| import javax.inject.Inject | ||
|
|
||
| @HiltViewModel | ||
| class LoginViewModel @Inject constructor( | ||
| private val userLoginUseCase: UserLoginUseCase, | ||
| ) : BaseViewModel() { | ||
| private val _loginState = MutableStateFlow<LoginState>(LoginState.Init) | ||
| val loginState: StateFlow<LoginState> = _loginState.asStateFlow() | ||
| private val _loginState = MutableSharedFlow<LoginState>() |
There was a problem hiding this comment.
단일성 이벤트를 위해서 변경한건가요?
https://medium.com/androiddevelopers/viewmodel-one-off-event-antipatterns-16a1da869b95
참고해보시면 좋을것 같네요
|
EventFlow를 만들어서 문제점을 개선할 수 있었습니다. 🗒️ 정리한 노션 : SharedFlow + EventFlow |
|
@yunjaena |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
버그
로그아웃 & 회원탈퇴 SingleLiveEvent value NPE
=> SharedFlow 로 변경
LoginViewModel StateFlow -> SharedFlow