Feature/hsgo/business change password api #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjaena
reviewed
Mar 31, 2024
| onBackPressed: () -> Unit | ||
| ) { | ||
| val context = LocalContext.current | ||
| var password by remember { mutableStateOf("") } |
There was a problem hiding this comment.
해당 변수를 State hoisting 해야될것 같습니다.
| ) { | ||
| val context = LocalContext.current | ||
| var password by remember { mutableStateOf("") } | ||
| var passwordChecked by remember { mutableStateOf("") } |
There was a problem hiding this comment.
해당 변수를 State hoisting 해야될것 같습니다.
| ): BaseViewModel() , ContainerHost<PasswordAuthenticationState, PasswordAuthenticationSideEffect> { | ||
| override val container = container<PasswordAuthenticationState, PasswordAuthenticationSideEffect>(PasswordAuthenticationState()) | ||
|
|
||
| private val _changePasswordContinuationState = SingleLiveEvent<ChangePasswordContinuationState>() |
There was a problem hiding this comment.
State Container가 있는데 SingleLiveEvent와 LiveDate를 쓸필요가 없을것 같습니다.
|
|
||
| fun sendAuthCode(email: String){ | ||
| if(isLoading.value == false){ | ||
| viewModelScope.launchWithLoading { |
There was a problem hiding this comment.
launchWIthLoading을 사용하지 말고 state에 loading상태를 선언해서 사용해보세요
data/src/main/java/in/koreatech/koin/data/di/network/NetworkModule.kt
Outdated
Show resolved
Hide resolved
| email: String | ||
| ): Result<ChangePasswordContinuationState> { | ||
| return when (email) { | ||
| "" -> Result.success(ChangePasswordContinuationState.ToastNullEmail) |
nayunjae
approved these changes
Apr 3, 2024
yunjaena
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
di를 모듈에 따라 분리하였습니다.