Feature/update dining response #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
16
to
+17
| @SerializedName("updated_at") val updatedAt: String, | ||
| @SerializedName("sold_out") val isSoldOut: Boolean, |
There was a problem hiding this comment.
sold_out 부분만 SerializedName하고 변수명이 다른데 이유가 있는 건가요?
There was a problem hiding this comment.
변수명 앞에 is 를 붙이면 boolean인지 바로 알 수 있어서 개인적인 컨벤션으로 쓰게 되더라고요! 바로 아래쪽에 isChanged 도 있어서 일관성 맞춰주기 위해 쓴 것도 있습니다
@junghaesung79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
작업사항
서버에서 넘어오는 값에 따라 response 구조에 이미지 url, 품절여부, 식단 변경을 추가했습니다.
참고사항
4월 3일에 이루어진 캠퍼스팀 주간공유 에서 품절 안내를
Boolean으로 하는대신 품절 시각을String으로 넘기기로 했습니다.아직 백엔드에서 반영되지 않았기 때문에 일단 boolean으로 했고, 반영 완료되면 주석처리된걸로 변경해주면 될 것 같습니다.