메인화면 식단 영역 리뉴얼 #218
Merged
메인화면 식단 영역 리뉴얼 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
yunjaena
reviewed
Apr 9, 2024
| @@ -8,6 +8,7 @@ sealed class DiningType( | |||
| object Breakfast : DiningType(0, "BREAKFAST", "아침") | |||
| object Lunch : DiningType(1, "LUNCH", "점심") | |||
| object Dinner : DiningType(2, "DINNER", "저녁") | |||
| object NextBreakfast : DiningType(3, "BREAKFAST", "내일 아침") | |||
There was a problem hiding this comment.
#217
여기에서 enum으로 변경된 것 같아서 217번 pr 머지 끝나고 차후에 반영해도 될까요?
반영 완료했습니다~
| @@ -18,6 +18,8 @@ object DiningUtil { | |||
| DiningType.Lunch | |||
| } else if (TimeUtil.compareWithCurrentTime(diningEndTime[2]) >= 0) { | |||
There was a problem hiding this comment.
diningEndTime forEach로 검색하거나 size check를 해주면 좋을것 같습니다.
wateralsie
force-pushed
the
feature/update-main-dining
branch
from
7bf944a to
85a047b
Compare
|
오늘 10시에 이 기능 포함 qa를 진행해야하는지라 바로 머지하는 점 양해 부탁드립니다...! |
|
앞으로는 pr 리뷰 보는 기간까지 산정해서 작업을 진행하면 좋을것 같네요. 오래 걸릴 것 같은면 스프린트기간을 조율해야된다고 생각합니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
작업사항
참고사항
서버에서 넘어오는 품절, 변경됨 상태값이 string으로 변경됨에 따라 반영해주었습니다. 식단 상세에서 이미 이루어졌다면 해당 커밋 지우도록 하겠습니다
구현 화면
(오전 5시 47분 기준)
