Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

영양사 페이지 진입점에 웹뷰 추가 #219

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

wateralsie
Copy link
Contributor

@wateralsie wateralsie commented Apr 9, 2024

이슈

작업사항

  • 사이드바 > 코인 for business 클릭시 웹뷰로 이동
  • 영양사 페이지 url 추가

참고사항

회의 당시에는 영양사 페이지랑 사장님 페이지랑 진입점이 동일할 수도 있다고 해서 일단 진입점을 코인 for business로 잡았어요
하지만 영양사 페이지 url 추가하면서 진입점이 수정될 가능성이 있습니다! url 나오는대로 변경해서 커밋 올리겠습니다

구현 화면

image

@wateralsie wateralsie self-assigned this Apr 9, 2024
@wateralsie wateralsie requested a review from a team as a code owner April 9, 2024 02:34
@wateralsie wateralsie linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link
Contributor

@ThirFir ThirFir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

.setNegativeButton("취소") { dialog, _ ->
dialog.cancel()
}
.setMessage("로그인이 필요한 서비스입니다.\n로그인 하시겠습니까?")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string resource를 사용하면 좋을 것 같습니다!!

Copy link
Contributor

@yunjaena yunjaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했습니다.

startActivity(intent)
overridePendingTransition(android.R.anim.slide_in_left, android.R.anim.fade_out)
}
.setNegativeButton("취소") { dialog, _ ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string resource 동일하게 넣어주세요

@wateralsie
Copy link
Contributor Author

@ThirFir @yunjaena
b339dcc 코드리뷰 반영 완료했습니다!

Copy link
Member

@skdud0629 skdud0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~~💯

@wateralsie wateralsie merged commit c6e7d48 into develop Apr 10, 2024
@wateralsie wateralsie deleted the feature/add-owner-webview branch April 10, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KOIN] 영양사 페이지 웹뷰 추가
4 participants