Skip to content

[Fix] 식단 상세 페이지 QA#229

Merged
ThirFir merged 11 commits intodevelopfrom
fix/dining-detail-reflect-qa
Apr 16, 2024
Merged

[Fix] 식단 상세 페이지 QA#229
ThirFir merged 11 commits intodevelopfrom
fix/dining-detail-reflect-qa

Conversation

@ThirFir
Copy link
Copy Markdown
Contributor

@ThirFir ThirFir commented Apr 15, 2024

개요

식단 상세 페이지 및 버스 QA 반영

상세 작업 내용

@ThirFir ThirFir requested a review from a team as a code owner April 15, 2024 04:11
@github-actions github-actions bot added the fix Code fix label Apr 15, 2024
@ThirFir ThirFir self-assigned this Apr 15, 2024
Copy link
Copy Markdown
Collaborator

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 👍

홈에서 버스 애니메이션을 없앤 이유는 팀 회의에서 결정된건가요?

@ThirFir
Copy link
Copy Markdown
Contributor Author

ThirFir commented Apr 16, 2024

홈에서 버스 애니메이션을 없앤 이유는 팀 회의에서 결정된건가요?

원래 기획에 없던 내용이기도 하고, 애니메이션 버그 수정에 공수를 들이는 것보단 다른 사항을 먼저 해결하는 것이 맞다고 판단되어 일단은 제거를 해놓는 것으로 결정하였습니다!!

Copy link
Copy Markdown
Contributor

@wateralsie wateralsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다👍👍

DiningType.Lunch -> tabsDiningTime.selectTab(tabsDiningTime.getTabAt(1))
DiningType.Dinner -> tabsDiningTime.selectTab(tabsDiningTime.getTabAt(2))
DiningType.NextBreakfast -> tabsDiningTime.selectTab(tabsDiningTime.getTabAt(0))
DiningType.NextBreakfast -> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiningType에서 NextBreakfast를 없애려고 하는데 혹시 이거 식단 상세에서 쓰이는지 궁금합니다!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 사용하고 있는 곳은 없어서 관련된 참조 모두 삭제하셔도 될 거 같습니다!!

@ThirFir ThirFir merged commit 8571f2e into develop Apr 16, 2024
@ThirFir ThirFir deleted the fix/dining-detail-reflect-qa branch May 1, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Code fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants