Conversation
Jokwanhee
approved these changes
Apr 16, 2024
Collaborator
Jokwanhee
left a comment
There was a problem hiding this comment.
고생하셨습니다~ 👍
홈에서 버스 애니메이션을 없앤 이유는 팀 회의에서 결정된건가요?
Contributor
Author
원래 기획에 없던 내용이기도 하고, 애니메이션 버그 수정에 공수를 들이는 것보단 다른 사항을 먼저 해결하는 것이 맞다고 판단되어 일단은 제거를 해놓는 것으로 결정하였습니다!! |
wateralsie
approved these changes
Apr 16, 2024
| DiningType.Lunch -> tabsDiningTime.selectTab(tabsDiningTime.getTabAt(1)) | ||
| DiningType.Dinner -> tabsDiningTime.selectTab(tabsDiningTime.getTabAt(2)) | ||
| DiningType.NextBreakfast -> tabsDiningTime.selectTab(tabsDiningTime.getTabAt(0)) | ||
| DiningType.NextBreakfast -> { |
Contributor
There was a problem hiding this comment.
DiningType에서 NextBreakfast를 없애려고 하는데 혹시 이거 식단 상세에서 쓰이는지 궁금합니다!
Contributor
Author
There was a problem hiding this comment.
따로 사용하고 있는 곳은 없어서 관련된 참조 모두 삭제하셔도 될 거 같습니다!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
식단 상세 페이지 및 버스 QA 반영
상세 작업 내용
close [KOIN] 메인화면 버스 자동 스크롤 제거 #223
close [KOIN] 버스 시간표 업데이트 날짜 UI 높이 수정 #224
close [KOIN] 칼로리, 가격 정보 없을 때 UI 제거 #225
close [KOIN] 식단 상세 페이지 달력 UI 수정 #226
기타