Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] GA4 클릭/스크롤 이벤트 추가 #245
[Feature] GA4 클릭/스크롤 이벤트 추가 #245
Changes from 26 commits
5b2965d
1398d58
d06b6cb
48eb8fd
bd58a08
6f8efda
506d28c
bf0ff79
9b2b890
a545e9f
047afef
174b67d
661e3b4
3f61213
05d14a7
be3a4c8
5389913
dbfb841
501bf3c
86341b2
ce63904
2ccb7a3
88a12f9
2fbe342
1251c4b
da22668
e91519e
a04c386
824ae39
2cc5f5b
be16867
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object in object 구조를 차용하는 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이벤트 로깅에 사용되는 상수임을 명확히 하기 위해 관련 상수들을 AnalyticsConstant라는 object 내에 배치하였고, 그 안에서도 각 상수들이 어떤 parameter에 쓰이는지 명확히 하기 위해 object로 다시 한 번 분류하였습니다.