상점 세부 페이지 기능 업데이트 #256
Merged
상점 세부 페이지 기능 업데이트 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
엇..왜 제 상점이 ㅋㅋㅋ 
기타정보는 왜 표시가 안될까용..? |
…igin/fix/store-detail # Conflicts: # koin/src/main/java/in/koreatech/koin/ui/store/fragment/StoreDetailEventFragment.kt
헉..코드 잘못날려서 다시 수정했습니다..! |
Jokwanhee
reviewed
May 8, 2024
| import `in`.koreatech.koin.util.ext.observeLiveData | ||
|
|
||
| class StoreDetailEventFragment : Fragment() { | ||
| private var _binding: FragmentStoreDetailEventBinding? = null |
There was a problem hiding this comment.
Fragment Destroy 될 때, binding 할당 객체 해제해주어야 할 것 같아요~
| import `in`.koreatech.koin.util.ext.observeLiveData | ||
|
|
||
| class StoreDetailMenuFragment : Fragment() { | ||
| private var _binding: FragmentStoreDetailMenuBinding? = null |
Comment on lines
110
to
125
| if(binding.storeDetailMainMenuTextView.text == category.name){ | ||
| binding.storeDetailMainMenuButton.setCardBackgroundColor(ContextCompat.getColor(requireContext(), R.color.colorPrimary)) | ||
| binding.storeDetailMainMenuTextView.setTextColor(Color.WHITE) | ||
| } | ||
| else if(binding.storeDetailSetMenuTextView.text == category.name){ | ||
| binding.storeDetailSetMenuButton.setCardBackgroundColor(ContextCompat.getColor(requireContext(), R.color.colorPrimary)) | ||
| binding.storeDetailSetMenuTextView.setTextColor(Color.WHITE) | ||
| } | ||
| else if (binding.storeDetailSideMenuTextView.text == category.name){ | ||
| binding.storeDetailSideMenuButton.setCardBackgroundColor(ContextCompat.getColor(requireContext(), R.color.colorPrimary)) | ||
| binding.storeDetailSideMenuTextView.setTextColor(Color.WHITE) | ||
| } | ||
| else{ | ||
| binding.storeDetailRecommendMenuButton.setCardBackgroundColor(ContextCompat.getColor(requireContext(), R.color.colorPrimary)) | ||
| binding.storeDetailRecommendMenuTextView.setTextColor(Color.WHITE) | ||
| } |
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="vertical"> |
# Conflicts: # data/src/main/java/in/koreatech/koin/data/api/StoreApi.kt # data/src/main/java/in/koreatech/koin/data/mapper/StoreMapper.kt # data/src/main/java/in/koreatech/koin/data/repository/StoreRepositoryImpl.kt # data/src/main/java/in/koreatech/koin/data/source/remote/StoreRemoteDataSource.kt # koin/build.gradle
…-detail # Conflicts: # koin/src/main/java/in/koreatech/koin/ui/store/fragment/StoreDetailEventFragment.kt
ThirFir
reviewed
May 8, 2024
| storeDetailIsCardTextview.isVisible = false | ||
| } | ||
|
|
||
| setEtcInfo(storeDetailIsCardTextview, it.isCardOk) |
There was a problem hiding this comment.
setEtcInfo(storeDetailIsCardTextview, it.isCardOk)가 두 번 쓰이고 있는데 수정이 필요할 거 같습니당
그리고 isAvailable을 매개변수로 넘기는 것 보다 isAvailable의 조건이 참일때만 setEtcInfo 함수를 호출하도록 하는 게 구조적으로 더 좋을거 같다는 의견입니당
| storeDetailEvent.visibility = View.VISIBLE | ||
| storeDetailEventExpand.visibility = View.GONE | ||
| } | ||
| storeDetailEventTitleTextview.text = shopEvent.title |
There was a problem hiding this comment.
함수로 구조화하는 게 유지보수에 더 용이할 거 같습니다..!
| viewModel.storeMenu.value?.let { | ||
| category.menus?.forEachIndexed { menuIndex, shopMenus -> | ||
| if (shopMenus.isSingle && shopMenus.singlePrice != null) { | ||
| shopMenus.singlePrice |
| ) : BaseViewModel() { | ||
| val store: LiveData<StoreWithMenu> get() = _store | ||
| private val _store = MutableLiveData<StoreWithMenu>() | ||
| val categories: LiveData<StoreMenu> get() = _categories | ||
| private var _categories = MutableLiveData<StoreMenu>() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
상점 세부 페이지 이벤트/공지 페이지 추가
메뉴 카테고리 별로 나누기
상세 작업 내용
메뉴 페이지
이벤트/공지 페이지
