Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration Groovy to Kotlin DSL #302

Merged
merged 14 commits into from
Jul 8, 2024
Merged

Migration Groovy to Kotlin DSL #302

merged 14 commits into from
Jul 8, 2024

Conversation

Jokwanhee
Copy link
Collaborator

요약

  • [project, data, domain, core, koin] buildg.gradle 대상으로 진행했습니다.
  • Groovy 언어를 Kotlin DSL 로 변경해봤습니다!
  • 중복되는 plugin 및 라이브러리 삭제를 했습니다!
  • HiltConvetionPlugin 부분이 application 만 사용가능하길래, library 도 사용할 수 있도록 변경했습니다!
  • AndroidLibraryConventionPlugin 을 추가했습니다.

아직 부족한 부분이 많아서 검토 한 번 해주시면 감사드리겠습니다..!
toml 라이브러리 쪽 정리하고 싶었는데, conflict 가 많이 날 것 같아서.. 우선 냅뒀습니다.

@Jokwanhee Jokwanhee self-assigned this Jul 1, 2024
@Jokwanhee Jokwanhee requested a review from a team as a code owner July 1, 2024 09:48
skdud0629
skdud0629 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@skdud0629 skdud0629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

ThirFir
ThirFir approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ThirFir ThirFir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

yunjaena
yunjaena requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@yunjaena yunjaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했습니다 :) 커멘트 확인해주세요!

build.gradle.kts Show resolved Hide resolved
data/build.gradle.kts Outdated Show resolved Hide resolved
domain/build.gradle.kts Outdated Show resolved Hide resolved
koin/build.gradle.kts Outdated Show resolved Hide resolved
yunjaena
yunjaena requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@yunjaena yunjaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 추가했습니다 :)

domain/build.gradle.kts Outdated Show resolved Hide resolved
domain/build.gradle.kts Outdated Show resolved Hide resolved
koin/build.gradle.kts Outdated Show resolved Hide resolved
yunjaena
yunjaena approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@yunjaena yunjaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 수고하셨습니다!

@Jokwanhee Jokwanhee merged commit af8f16e into develop Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skdud0629 skdud0629 skdud0629 approved these changes

@ThirFir ThirFir ThirFir approved these changes

@yunjaena yunjaena yunjaena approved these changes

Assignees

@Jokwanhee Jokwanhee

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jokwanhee @yunjaena @ThirFir @skdud0629