[Feature] 사장님 로그인 기능 구현 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/hsgo/business_login # Conflicts: # business/src/main/java/in/koreatech/business/BusinessMainActivity.kt # business/src/main/java/in/koreatech/business/feature/changepassword/changepassword/ChangePasswordScreen.kt # business/src/main/java/in/koreatech/business/feature/changepassword/changepassword/ChangePasswordSideEffect.kt # business/src/main/java/in/koreatech/business/feature/changepassword/changepassword/ChangePasswordState.kt # business/src/main/java/in/koreatech/business/feature/changepassword/changepassword/ChangePasswordViewModel.kt # business/src/main/java/in/koreatech/business/feature/changepassword/finishchangepassword/FinishChangePasswordScreen.kt # business/src/main/java/in/koreatech/business/feature/changepassword/navigator/ChangePasswordRoute.kt # business/src/main/java/in/koreatech/business/feature/changepassword/navigator/FeatureChangePassword.kt # business/src/main/java/in/koreatech/business/feature/changepassword/passwordauthentication/PasswordAuthenticationScreen.kt # business/src/main/java/in/koreatech/business/feature/changepassword/passwordauthentication/PasswordAuthenticationSideEffect.kt # business/src/main/java/in/koreatech/business/feature/changepassword/passwordauthentication/PasswordAuthenticationState.kt # business/src/main/java/in/koreatech/business/feature/changepassword/passwordauthentication/PasswordAuthenticationViewModel.kt # business/src/main/java/in/koreatech/business/feature/findpassword/changepassword/ChangePasswordViewModel.kt # business/src/main/java/in/koreatech/business/feature/findpassword/navigator/ChangePasswordRoute.kt # business/src/main/java/in/koreatech/business/feature/findpassword/navigator/FeatureChangePassword.kt # business/src/main/java/in/koreatech/business/feature/findpassword/passwordauthentication/PasswordAuthenticationSideEffect.kt # business/src/main/java/in/koreatech/business/feature/insertstore/finishregisterstore/FinishRegisterStore.kt # business/src/main/java/in/koreatech/business/feature_changepassword/changepassword/ChangePasswordViewModel.kt # business/src/main/java/in/koreatech/business/feature_changepassword/finishchangepassword/FinishChangePasswordScreen.kt # business/src/main/java/in/koreatech/business/feature_changepassword/navigator/ChangePasswordRoute.kt # business/src/main/java/in/koreatech/business/feature_changepassword/navigator/FeatureChangePassword.kt # business/src/main/java/in/koreatech/business/feature_changepassword/passwordauthentication/PasswordAuthenticationSideEffect.kt # core/src/main/res/values/strings.xml # data/src/main/java/in/koreatech/koin/data/error/UserErrorHandlerImpl.kt # data/src/main/res/values/strings.xml
yunjaena
requested changes
Sep 13, 2024
| intent { | ||
| reduce { | ||
| state.copy(notValidateField = true) | ||
| } |
There was a problem hiding this comment.
ShowNullMessage 보다 ShowErrorMessage가 낫지 않을까요?
There was a problem hiding this comment.
바꾸는걸 깜빡했네요... 수정하겠습니다!
| id -> viewModel.insertId(id) | ||
| }, | ||
| onPasswordChange = { | ||
| password -> viewModel.insertPassword(password) |
There was a problem hiding this comment.
Suggested change
| password -> viewModel.insertPassword(password) | |
| password -> viewModel::insertPassword |
There was a problem hiding this comment.
이런 방법이 있었군요...!
한번 공부를 해봐야겠어요!
There was a problem hiding this comment.
이런 방법이 있군요...
한번 공부를 해봐야겠네요!
| else if(state.password.isBlank()) postSideEffect(SignInSideEffect.ShowNullMessage(ErrorType.NullPassword)) | ||
| } | ||
| } | ||
| private fun toastErrorMessage(message: String) = intent { |
There was a problem hiding this comment.
Suggested change
| private fun toastErrorMessage(message: String) = intent { | |
| private fun showErrorMessage(message: String) = intent { |
나중에 toast가 될수도 있고 snackbar이 될수도 있으니 범용적으로 메소드 명을 짓는거는 어떨까요?
There was a problem hiding this comment.
수정했어야 했는데 깜빡했나보네요 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
상세 작업 내용
작업 결과물