[Feature] 메뉴 등록 및 수정 기능에서 카메라 촬영 기능 추가 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsgo2430
changed the title
yunjaena
requested changes
Sep 25, 2024
business/src/main/java/in/koreatech/business/navigation/BusinessNavHost.kt
Outdated
Show resolved
Hide resolved
Jokwanhee
reviewed
Sep 25, 2024
.../main/java/in/koreatech/business/feature/storemenu/modifymenu/modifymenu/ModifyMenuScreen.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+46
to
+51
| fun createImageFile(context: Context): Uri? { | ||
| val contentResolver = context.contentResolver | ||
| val content = ContentValues().apply { | ||
| put(MediaStore.MediaColumns.MIME_TYPE, "image/jpeg") | ||
| } | ||
| return contentResolver.insert(MediaStore.Images.Media.EXTERNAL_CONTENT_URI, content) |
There was a problem hiding this comment.
File 유틸 클래스 만들어서 추상화해도 괜찮을 것 같은데 같은데, 어떠시오? 🤠
There was a problem hiding this comment.
추상화.... 한번 만들어볼게요!
Jokwanhee
approved these changes
Sep 26, 2024
yunjaena
requested changes
Sep 26, 2024
business/src/main/java/in/koreatech/business/BusinessMainActivity.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
상세 작업 내용
작업 결과물