Skip to content

[Feature] 컴포넌트 추가 #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 31, 2024
Merged

[Feature] 컴포넌트 추가 #444

merged 14 commits into from
Oct 31, 2024

Conversation

ThirFir
Copy link
Contributor

@ThirFir ThirFir commented Oct 30, 2024

개요

  • designsystem 모듈 내 component 패키지에 컴포넌트 일부 추가
  • 버튼, 칩, 탭 레이아웃, 앱 바, 텍스트
  • 리플없는 clickable 추가

작업 상세

버튼

image

텍스트 칩 and 텍스트 칩 그룹

image

기본 탭 레이아웃

image

기본 앱바

image

아이콘+텍스트

image

@ThirFir ThirFir requested a review from a team as a code owner October 30, 2024 16:34
Copy link
Collaborator

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요~ 🙇🏻 noripple 왔다! 👀

@ThirFir ThirFir self-assigned this Oct 31, 2024
Copy link
Collaborator

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
코멘트 한번만 확인 부탁드려요 :)

Copy link
Collaborator

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@ThirFir ThirFir merged commit 7d72029 into develop Oct 31, 2024
@nodobi
Copy link
Contributor

nodobi commented Nov 1, 2024

조금 늦은 코멘트긴 하지만.. 디자인 시스템에서 더이상 쪼갤 수 없는 단위의 컴포넌트를 atom 이라는 카테고리로 묶는 경우도 있더라구요.
지금은 정확한 명세가 없다보니 컴포넌트 폴더로 묶어두고 나중에 디자인 시스템 관련해서 진행되는거 있으면 말씀드리고 분리 진행해보겠습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants