Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 사장님 앱 버그 수정 #455

Merged
merged 5 commits into from
Nov 6, 2024
Merged

[Fix] 사장님 앱 버그 수정 #455

merged 5 commits into from
Nov 6, 2024

Conversation

skdud0629
Copy link
Member

작업내용

  • 회원가입시 비밀번호 sha256적용
  • ui 잘림 해결
  • 회원가입 요청 로직 변경
  • 이벤트 아이템 이미지 안 나오는 버그 수정

@skdud0629 skdud0629 self-assigned this Nov 5, 2024
@skdud0629 skdud0629 requested a review from a team as a code owner November 5, 2024 08:14
@skdud0629 skdud0629 changed the base branch from production to develop November 5, 2024 08:14
@github-actions github-actions bot added the fix label Nov 5, 2024
Copy link
Contributor

@hsgo2430 hsgo2430 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!

Copy link

@https-namhoon-kim https-namhoon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 전반적으로 코드 컨벤션이 맞지않는 느낌을 많이 받습니다.
    • 생성자는 어디는 내려쓰고 어디는 인라인이고
    • argument도 다 내려쓰던가해주세요.
  • 버그를 고친 브랜치인데 변경사항이 너무 과도하게 많습니다. 이슈를 나눠서 해결하는 습관을 들이세요.

@skdud0629 skdud0629 merged commit 01416d6 into develop Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants