Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 시간표 로그인 기능 구현 #458

Merged
merged 43 commits into from
Nov 7, 2024
Merged

[Feature] 시간표 로그인 기능 구현 #458

merged 43 commits into from
Nov 7, 2024

Conversation

Jokwanhee
Copy link
Collaborator

요약

  • 로그인 기능 구현
    • 강의 추가, 정규 강의 삭제
  • 직접 추가 UI 구현
    • 비로그인 시, 로그인 팝업
    • 로그인 시, 직접 추가 UI 노출

전달사항

  • 시간표 강의 클릭 시, 오프셋 변경으로 스크롤 트래킹 추가했는데, 나름 괜찮은 인터렉션 같다고 생각하는데 어떤가요!?
  • 레포지토리 받아서 하는 테스트 코드 싹다 주석했어요.. 이유는 레포지토리가 계속 변경되면 FakeRepository도 변경되어서 ㅠㅠ

시연영상

  • [비로그인] 직접 추가 클릭 시, 로그인 모달창
PR1.mp4
  • [로그인] 강의 추가, 삭제
PR2.mp4
  • 강의 스크롤 트래킹 기능 구현
2024-11-05.7.mp4

@Jokwanhee
[add] 추가된 강의 추가 클릭 리스너 연결
b7c42e0
@Jokwanhee
[add] lectureId 추가
142b9b9
@Jokwanhee
[add] GET Frame API 연결
93bb138
@Jokwanhee
[add] 빈 리스트 받더라도 학기 추가
014aa0c
@Jokwanhee
[fix] 테스트 코드 주석처리
95c72c3
@Jokwanhee
[add] api 추가 및 연결
5327f3f
@Jokwanhee
[add] 시간표 추가 유즈케이스 구현
8e8c91d
@Jokwanhee
[add] 시간표 정규 강의 삭제 유즈케이스 구현
c8374a6
@Jokwanhee
[add] 시간표 선택 강의 삭제 유즈케이스 구현
b2c677b
@Jokwanhee
[fix] 학기 유즈케이스 수정
ee56326
@Jokwanhee
[fix] lectureId로 변경
4069e30
@Jokwanhee
[add] TimeEditBox UI 구현
9256300
@Jokwanhee
[add] TimetableCustomAddBox UI 구현
12f2b71
@Jokwanhee
[add] TimetableInputField UI 구현
8b77176
@Jokwanhee
[add] TimetableTimeContentRow UI 구현
08266dd
@Jokwanhee
[del] 샘플 코드 삭제
75cdf86
@Jokwanhee
[add] TimetableBottomSheetBasic 섹션 추가
dd81097
@Jokwanhee
[add] TimetableBottomSheetCustom UI 구현
aea9b0e
@Jokwanhee
[add] BottomSheet Custom내부 UI 구현
7d40ef6
@Jokwanhee
[add] TimetableBottomSheetHeader mode 추가
0d65301
@Jokwanhee
[fix] TimetableBottomSheet UI 구분
84759b9
@Jokwanhee
[add] 리소스 추가
7442bbf
@Jokwanhee
[add] 리소스 아이콘 xml 적용
fc1b0c4
@Jokwanhee
[add] 클릭 리스너 연결 및 로직 구현
56588e1
@Jokwanhee
[fix] Timetable 뷰모델 기능 구현 및 수정
15b4f55
@Jokwanhee
[add] immutable dependency 추가
7bc3990
@Jokwanhee
[add] 이벤트 트래킹 기능 구현
10d8650
@Jokwanhee
[fix] 바텀시트 높이 고정 dp 로 변경
a8ca4c2
@Jokwanhee
[add] 로그인 시 중복 추가에 대한 로직 준비
8e07ec0
@Jokwanhee
[add] contentPadding 추가
d2be18a
@Jokwanhee Jokwanhee self-assigned this Nov 5, 2024
@Jokwanhee Jokwanhee requested a review from a team as a code owner November 5, 2024 10:59
ThirFir
ThirFir approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@ThirFir ThirFir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어여 트래킹 기능 좋네요~
어프해놓을게용

data/src/main/java/in/koreatech/koin/data/request/timetable/LecturesQueryRequest.kt Outdated Show resolved Hide resolved
domain/src/main/java/in/koreatech/koin/domain/usecase/timetable/AddTimetableLectureUseCase.kt Outdated Show resolved Hide resolved
...timetable/src/main/java/in/koreatech/koin/feature/timetable/component/TimetableInputField.kt Outdated Show resolved Hide resolved
...timetable/src/main/java/in/koreatech/koin/feature/timetable/component/TimetableInputField.kt Outdated Show resolved Hide resolved
...table/src/main/java/in/koreatech/koin/feature/timetable/component/TimetableTimeContentRow.kt Outdated Show resolved Hide resolved
...etable/src/main/java/in/koreatech/koin/feature/timetable/section/BottomSheetCustomContent.kt Outdated Show resolved Hide resolved
...table/src/main/java/in/koreatech/koin/feature/timetable/section/TimetableBottomSheetBasic.kt Show resolved Hide resolved
feature/timetable/src/main/java/in/koreatech/koin/feature/timetable/view/Timetable.kt Outdated Show resolved Hide resolved
...ure/timetable/src/main/java/in/koreatech/koin/feature/timetable/view/TimetableBottomSheet.kt Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
nodobi
nodobi approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@nodobi nodobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크롤 트래킹 너무 좋은 거 같아요!! 고생하셨습니다!

data/src/main/java/in/koreatech/koin/data/repository/TimetableRepositoryImpl.kt Show resolved Hide resolved
@Jokwanhee Jokwanhee merged commit 42fdaae into develop Nov 7, 2024
@Jokwanhee Jokwanhee deleted the feature/timetable_api_v2 branch December 10, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThirFir ThirFir ThirFir approved these changes

@nodobi nodobi nodobi approved these changes

Assignees

@Jokwanhee Jokwanhee

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jokwanhee @nodobi @ThirFir